Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data corruption during reads on Linux/OSX #17592

Closed
rmja opened this issue Sep 3, 2019 · 4 comments
Closed

Data corruption during reads on Linux/OSX #17592

rmja opened this issue Sep 3, 2019 · 4 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Milestone

Comments

@rmja
Copy link

rmja commented Sep 3, 2019

The currentlly released version of Microsoft.Data.SqlClient (1.0.19239.1) has a severe issue (dotnet/SqlClient#145 (comment)) where data corruption happens for read values that spans two packets. The error only happens when the managed tds parser is used which it is on Linux and OSX.

Corrupted reads may throw an exception because it can cause an invalid state in the internal tds parser, but it can also happen that corrupted values can be silently read.

A fix is merged to master (dotnet/SqlClient#171) but is scheduled for a 1.1 release which is likely after the release of EF Core 3.

This issue is intended to track the release of M.D.SqlClient and to make sure that the dependency is upgraded if it happens that a patch release out before the release of EF Core 3.

Further technical details

EF Core version: 3.0 preview 8
Database Provider: SqlServer with M.D.SqlClient
Operating system: Linux and OSX

@rmja
Copy link
Author

rmja commented Sep 6, 2019

@ajcvickers this have now been released I M.D.SqlClient so it is now ready to be fixed

@ajcvickers
Copy link
Contributor

@rmja Thanks. @bricelam is working on a PR, which we will then need to get approved.

@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Sep 9, 2019
@rmja
Copy link
Author

rmja commented Sep 17, 2019

@ajcvickers @bricelam Is it correct that this change is not included in rc1?

image

@smitpatel
Copy link
Contributor

@rmja - That is true. It will be included in 3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Projects
None yet
Development

No branches or pull requests

4 participants