Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IQueryOptimizer/QueryOptimizer non-internal #12756

Closed
austindrenski opened this issue Jul 21, 2018 · 3 comments
Closed

Make IQueryOptimizer/QueryOptimizer non-internal #12756

austindrenski opened this issue Jul 21, 2018 · 3 comments
Assignees
@smitpatel
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Milestone
3.0.0

Comments

@austindrenski
Copy link
Contributor

In the provider for PostgreSQL, we are exploring some complex translations via IQueryOptimizer/QueryOptimizer which provide an extensibility point for injecting expression visitors.

However, we are wary of replacing services from the EF Core Internal namespaces.

Would it be possible to move IQueryOptimizer and QueryOptimizer out of the internal namespace?

current:  Microsoft.EntityFrameworkCore.Query.Internal
proposed: Microsoft.EntityFrameworkCore.Query

Related:

/cc @roji
@ajcvickers
Copy link
Member

We are going to consider this as part of the general 3.0 query work, so adding a link to #12795.

@ajcvickers ajcvickers added this to the 3.0.0 milestone Jul 30, 2018
@ajcvickers ajcvickers mentioned this issue Jul 30, 2018
Closed
@austindrenski
Copy link
Contributor Author

@ajcvickers Thanks for the update—much appreciated!

@smitpatel
Copy link
Member

The optimizations from IQueryOptimizer has been moved to QueryOptimizer which is public.

@smitpatel smitpatel added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed relinq-dependent labels Jun 5, 2019
@smitpatel smitpatel modified the milestones: 3.0.0, 3.0.0-preview6 Jun 5, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview6, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@ajcvickers @smitpatel @austindrenski