Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider always doing server evaluation for functions that don't have client implementation #11466

Closed
divega opened this issue Mar 29, 2018 · 0 comments
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@divega
Copy link
Contributor

divega commented Mar 29, 2018

For SQL Server we are adding the FreeText function in 2.1 that doesn't have a client evaluation. If we end up needing to evaluate this function after we have switched to client evaluation, we throw an exception.

Another example is DateTime.Now (and other similar properties). We want to evaluate this always on the server to avoid using inconsistent times and time zones.

We could instead turn this into a simple singleton query that evaluates the function on the server.

In the case of a function like FreeText, things are more complicated because it needs to be evaluated against a row in a table, but we can produce a query using the same table, the same columns and the same row (by using the key in the WHERE clause).

See the related discussion in the context of Npgsql support for full-text-search: npgsql/efcore.pg#315 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

No branches or pull requests

3 participants