From 9a7e792bea19ccb7a98830cc09435000f4a6d7c9 Mon Sep 17 00:00:00 2001 From: Andriy Svyryd Date: Fri, 29 Apr 2022 17:33:11 -0700 Subject: [PATCH] Allow to configure provider value comparer Fixes #27738 --- .../Infrastructure/RelationalModelValidator.cs | 6 +++--- test/EFCore.Specification.Tests/CustomConvertersTestBase.cs | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs b/src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs index a284accdf5a..8711ffdbf8b 100644 --- a/src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs +++ b/src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs @@ -1318,7 +1318,7 @@ protected override void ValidateInheritanceMapping( var mappingStrategy = (string?)entityType[RelationalAnnotationNames.MappingStrategy]; if (mappingStrategy != null) { - ValidateMappingStrategy(mappingStrategy, entityType); + ValidateMappingStrategy(entityType, mappingStrategy); var storeObject = entityType.GetSchemaQualifiedTableName() ?? entityType.GetSchemaQualifiedViewName() ?? entityType.GetFunctionName(); @@ -1389,9 +1389,9 @@ protected override void ValidateInheritanceMapping( /// /// Validates that the given mapping strategy is supported /// - /// The mapping strategy. /// The entity type. - protected virtual void ValidateMappingStrategy(string? mappingStrategy, IEntityType entityType) + /// The mapping strategy. + protected virtual void ValidateMappingStrategy(IEntityType entityType, string? mappingStrategy) { switch (mappingStrategy) { diff --git a/test/EFCore.Specification.Tests/CustomConvertersTestBase.cs b/test/EFCore.Specification.Tests/CustomConvertersTestBase.cs index cd639c580e5..870a0086f1e 100644 --- a/test/EFCore.Specification.Tests/CustomConvertersTestBase.cs +++ b/test/EFCore.Specification.Tests/CustomConvertersTestBase.cs @@ -254,7 +254,7 @@ public Fuel(double volume) public double Volume { get; } } - [ConditionalFact(Skip = "Issue #27738")] + [ConditionalFact] public virtual void Can_insert_and_read_back_with_case_insensitive_string_key() { using (var context = CreateContext())