Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document WinHttpHandler trailing header feature #5404

Open
antonfirsov opened this issue Mar 10, 2021 · 1 comment
Open

Document WinHttpHandler trailing header feature #5404

antonfirsov opened this issue Mar 10, 2021 · 1 comment
Labels
area-System.Net Pri3 Indicates issues/PRs that are low priority untriaged New issue has not been triaged by the area owner

Comments

@antonfirsov
Copy link
Member

antonfirsov commented Mar 10, 2021

We should document the new WinHttpHandler trailing header management feature (dotnet/runtime#44778) as impemented in dotnet/runtime#48704.

I recommend to add the docs to the Remarks section.

Key points:

  • Currently works only on Windows Manganese (Windows Server for Fe/21H1, aka Windows Server 2022 Build>=19622 if I get it right), but it's under backport, we need to collect proper version info.
    • No trailers are reported if the OS does not support WINHTTP_QUERY_FLAG_TRAILERS.
  • On netstandard2.1+ targets, trailers are added to HttpResponseMessage.TrailingHeaders
  • On .NET Framework, trailers are added to HttpRequestMessage.Properties["__ResponseTrailers"]. Use with caution and only in well justified compatibility scenarios, since the property is obsolete
@dotnet-bot dotnet-bot added the untriaged New issue has not been triaged by the area owner label Mar 10, 2021
@PRMerger7 PRMerger7 added the Pri3 Indicates issues/PRs that are low priority label Mar 10, 2021
@antonfirsov antonfirsov changed the title Document WinHttpHandler trailing header feature in WinHttpHandler Document WinHttpHandler trailing header feature Mar 10, 2021
@alexchro93
Copy link

alexchro93 commented Jan 7, 2022

Currently works only on Windows Manganese (Windows Server for Fe/21H1, aka Windows Server 2022 Build>=19622 if I get it right), but it's under backport, we need to collect proper version info.

hi @antonfirsov, is there any documentation out there currently that says which versions of Windows support this feature? I'm fairly certain most generally available builds of Windows 11 and Server 2022 support trailing headers, but I'm interested to hear if it was ever backported to a recent release of Windows 10 or Server 2019?

I'd run a test to check but I don't currently have access to a build of Windows 10 or Server 2019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Net Pri3 Indicates issues/PRs that are low priority untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

No branches or pull requests

4 participants