Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #10633 - multiple statements simplified by removing explicit comparison #10698

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes #10633 - multiple statements simplified by removing explicit comparison #10698

wants to merge 2 commits into from

Conversation

robbyc073
Copy link

Summary

Multiple if and while statements simplified by removing explicit comparison and replacing with logical NOT operator as required.

Fixes #10633

@robbyc073 robbyc073 requested a review from a team as a code owner November 20, 2024 22:28
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 20, 2024
@robbyc073
Copy link
Author

@dotnet-policy-bot agree

@robbyc073
Copy link
Author

@dotnet-policy-service agree

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 9d92d19:

✅ Validation status: passed

File Status Preview URL Details
snippets/common/VS_Snippets_WebNet/Classic RequiredFieldValidator Example/Common/source.xml ✅Succeeded View
snippets/cpp/VS_Snippets_CLR_System/system.GC.ReRegisterForFinalize Example/CPP/class1.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_CLR/AsyncDelegateExamples/cpp/polling.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_CLR/console.beep/CPP/beep.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_CLR/console.cursorvis/CPP/vis.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_CLR/console.keyavailable/CPP/ka.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_CLR/directoryinfocreatesub/CPP/directoryinfocreatesub.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_CLR/T.TryParse/CPP/tp.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/ClassicTcpClient.PublicMethodsAndPropertiesExample/CPP/source.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/DiscoveryDocument_DiscoveryDocument/CPP/discoverydocument_discoverydocument.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/DiscoveryExceptionDictionary_Property_Method/CPP/discoveryexceptiondictionary_property_method.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/DiscoveryReferenceCollection/CPP/discoveryreferencecollection.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/IChannelReceiver_StartListening_ChannelData/CPP/ichannelreceiver_channeldata_server.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/Message.Acknowledgment/CPP/message_acknowledgment.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/MessageQueue.Receive_TimeoutTransaction/CPP/mqreceive_timeouttransaction.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/MessageQueue.Receive_transaction/CPP/mqreceive_transaction.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/MessageQueue.Send_obj/CPP/mqsend_generic.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/MessageQueue.Send_ObjectTransaction/CPP/mqsend_objtransaction.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/NCLCredPolicy/CPP/NCLCredPolicy.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/NCLFtpClient/CPP/ftptests.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/NclMailASync/cpp/mailasync.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/NCLNetInfo2/CPP/networkexamples.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/NclSslClientAsync/CPP/NclSslClientAsync.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/NCLUriEnhancements/CPP/nclurienhancements.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/NCLUriExamples/CPP/uriexamples.cpp ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Poor (beginner) if statements
1 participant
@robbyc073