Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CA1862 and CA1863 #38344

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Add CA1862 and CA1863 #38344

merged 3 commits into from
Nov 21, 2023

Conversation

@gewarren gewarren requested a review from a team as a code owner November 20, 2023 23:27
@dotnet-bot dotnet-bot added this to the November 2023 milestone Nov 20, 2023
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@carlossanlop
Copy link
Member

We had a behavioral change for CA1862 introduced after the initial commit. Can you please make sure to mention it? Here is the PR with the behavior change: dotnet/roslyn-analyzers#6928

@gewarren gewarren merged commit a99b608 into dotnet:main Nov 21, 2023
8 checks passed
@gewarren gewarren deleted the ca1862 branch November 21, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants