Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document recent changes to JsonIncludeAttribute/JsonConstructorAttribute #36128

Closed
Tracked by #37101
eiriktsarpalis opened this issue Jul 7, 2023 · 3 comments
Closed
Tracked by #37101

Document recent changes to JsonIncludeAttribute/JsonConstructorAttribute #36128

eiriktsarpalis opened this issue Jul 7, 2023 · 3 comments
Assignees
@eiriktsarpalis @gewarren
Labels
area-System.Text.Json 🏁 Release: .NET 8 Work items for the .NET 8 release doc-idea Indicates issues that are suggestions for new topics [org][type][category] Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest.

Comments

@eiriktsarpalis
Copy link
Member

eiriktsarpalis commented Jul 7, 2023 •
edited by github-actions bot
Loading

I just merged a PR that somewhat extends the semantics of JsonIncludeAttribute and JsonConstructorAttribute. We should ensure any documentation of these attributes is updated to reflect the new semantics.

Associated WorkItem - 166837
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Jul 7, 2023
@eiriktsarpalis eiriktsarpalis self-assigned this Jul 7, 2023
@gewarren gewarren added doc-idea Indicates issues that are suggestions for new topics [org][type][category] Pri1 High priority, do before Pri2 and Pri3 and removed Pri3 labels Jul 18, 2023
@TanvirArjel

This comment was marked as off-topic.

Sign in to view
@eiriktsarpalis eiriktsarpalis mentioned this issue Aug 15, 2023
Closed
@eiriktsarpalis
Copy link
Member Author

Hi @TanvirArjel, I've marked your comment as off-topic, let's resolve this in dotnet/runtime#90577

@gewarren gewarren added 🏁 Release: .NET 8 Work items for the .NET 8 release and removed ⌚ Not Triaged Not triaged labels Aug 29, 2023
@gewarren gewarren self-assigned this Aug 29, 2023
@gewarren gewarren mentioned this issue Sep 13, 2023
Closed
11 tasks
@gewarren gewarren added the 🗺️ reQUEST Triggers an issue to be imported into Quest. label Oct 2, 2023
@github-actions github-actions bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Oct 3, 2023
@gewarren gewarren moved this from 🔖 Ready to 🏗 In progress in dotnet/docs October 2023 sprint Oct 17, 2023
@gewarren gewarren mentioned this issue Oct 17, 2023
Merged
@gewarren
Copy link
Contributor

This was done in https://github.com/dotnet/docs/pull/36549/files#diff-66d2f17cdbed8f262e53a87f0fb69db41150f6dcb45d6d572c49134a71ff9b34.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in dotnet/docs October 2023 sprint Oct 17, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in .NET 8.0 work items Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eiriktsarpalis eiriktsarpalis

@gewarren gewarren

Labels
area-System.Text.Json 🏁 Release: .NET 8 Work items for the .NET 8 release doc-idea Indicates issues that are suggestions for new topics [org][type][category] Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest.
Projects
No open projects
.NET 8.0 work items
Status: ✅ Done
dotnet/docs October 2023 sprint
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eiriktsarpalis @dotnet-bot @TanvirArjel @gewarren