Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change]: Features marked as Obsolete in .NET 7 #31401

Closed
1 of 2 tasks
ViktorHofer opened this issue Sep 26, 2022 · 1 comment · Fixed by #31936
Closed
1 of 2 tasks

[Breaking change]: Features marked as Obsolete in .NET 7 #31401

ViktorHofer opened this issue Sep 26, 2022 · 1 comment · Fixed by #31936
Assignees
Labels
breaking-change Indicates a .NET Core breaking change 🏁 Release: .NET 7 Work items for the .NET 7 release doc-idea Indicates issues that are suggestions for new topics [org][type][category] Pri1 High priority, do before Pri2 and Pri3 source incompatible Source code may encounter a breaking change in behavior when targeting the new version.

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Sep 26, 2022

Description

Starting with .NET 7 Preview 3, a small set of APIs which were previously announced to be made obsolete are now effectively marked as obsolete via the ObsoleteAttribute and will impact the developer's build. This is a continuation of #20894 which announced several APIs as obsolete but never made the corresponding change in the core libraries.

Version

Other (please put exact version in description textbox)

Previous behavior

These APIs could be referenced without any build warnings.

New behavior

References to these APIs will produce build warnings with the corresponding diagnostics.

Type of breaking change

  • Binary incompatible: Existing binaries may encounter a breaking change in behavior, such as failure to load/execute or different run-time behavior.
  • Source incompatible: Source code may encounter a breaking change in behavior when targeting the new runtime/component/SDK, such as compile errors or different run-time behavior.

Reason for change

These APIs were marked as obsolete for different reasons.

Recommended action

Follow the recommended action that is emitted when using the obsolete API.

Feature area

Core .NET libraries

Affected APIs

The following APIs are now correctly marked as Obsolete and will impact the build:

  • System.ComponentModel.IComNativeDescriptorHandler
  • System.ComponentModel.MemberDescriptor.GetInvokee(Type, Object)
  • System.Data.OleDb.OleDbParameterCollection.Add(String, Object)
  • System.Net.FileWebRequest.GetObjectData(*)
  • System.Net.FileWebResponse.GetObjectData(*)
  • System.Net.HttpWebRequest.HttpWebRequest(SerializationInfo, StreamingContext)
  • System.Net.HttpWebRequest.GetObjectData(*)
  • System.Net.WebResponse.WebResponse(SerializationInfo, StreamingContext)
  • System.Net.WebResponse.GetObjectData(*)
  • System.Security.Cryptography.PasswordDeriveBytes.GetBytes(int)
  • System.Web.HttpUtility.UrlEncodeUnicode(string)
  • System.Web.HttpUtility.UrlEncodeUnicodeToBytes(string)
@ViktorHofer ViktorHofer added doc-idea Indicates issues that are suggestions for new topics [org][type][category] breaking-change Indicates a .NET Core breaking change Pri1 High priority, do before Pri2 and Pri3 labels Sep 26, 2022
@dotnet-bot dotnet-bot added 🏁 Release: .NET 7 Work items for the .NET 7 release ⌚ Not Triaged Not triaged labels Sep 26, 2022
@gewarren gewarren removed the ⌚ Not Triaged Not triaged label Sep 26, 2022
@dotnet-bot dotnet-bot added the source incompatible Source code may encounter a breaking change in behavior when targeting the new version. label Sep 26, 2022
@gewarren gewarren moved this to 🔖 Ready in dotnet/docs October Sprint Sep 26, 2022
@gewarren
Copy link
Contributor

gewarren commented Sep 30, 2022

@ViktorHofer I have some questions about how I should document this. The description says the obsoletions were previously announced, but for the first few APIs I checked, I didn't find them in the original obsoletion breaking change notice for .NET 5. So perhaps not all of these were previously announced?

@ghost ghost added the in-pr This issue will be closed (fixed) by an active pull request. label Oct 20, 2022
Repository owner moved this from 🔖 Ready to ✅ Done in dotnet/docs October Sprint Nov 8, 2022
@ghost ghost removed the in-pr This issue will be closed (fixed) by an active pull request. label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Indicates a .NET Core breaking change 🏁 Release: .NET 7 Work items for the .NET 7 release doc-idea Indicates issues that are suggestions for new topics [org][type][category] Pri1 High priority, do before Pri2 and Pri3 source incompatible Source code may encounter a breaking change in behavior when targeting the new version.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants