-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F# style guidelines: no advice given for reverse pipeline operator #21459
Comments
I would like to point out that the recommendation has a 'vanity' indentation problem I believe. If it were failwithSuperLongBananas <| sprintf "foobar: %s - foobarbaz: %s"
foobar
foobarbaz where failwithSuperLongBananas
<| sprintf "foobar: %s - foobarbaz: %s" foobar foobarbaz does not have this problem. @cmeeren, @pragmatrix, @lydell this is the place do discuss these things ;) |
For reference, the Fantomas issue mentioning vanity indentation: fsprojects/fantomas#659 |
@nojaf What do you mean by
Are you saying that the Fantomas repo is not the place to discuss the issue @lydell linked to above, and that unless this is rectified in the official style guidelines, vanity indentation won't be changed in Fantomas? If so, remember, the guidelines are just that, guidelines :) (Mandatory Captain Barbossa meme) In any case, I think the linked issue pretty much sums up why vanity indentation might not be a good idea. |
Makes me giggle but I suppose it's the least friction. Happy to accept a PR! |
@cmeeren, style needs to discussed over here and what gets in this style guide gets in Fantomas. |
Issue description
Advice is given about how to use forward pipeline operators
|>
(chaining them by putting an EOL character next to them on the left side), e.g.However, what to do with reverse pipeline operators? Splitting them in the same way looks odd, e.g.:
So I recommend that an example is given which looks like the following:
Document details added by adegeo
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
The text was updated successfully, but these errors were encountered: