Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to System.Text.Json #9727

Open
just-ero opened this issue Feb 23, 2024 · 1 comment
Open

Migrating to System.Text.Json #9727

just-ero opened this issue Feb 23, 2024 · 1 comment
Labels
fundamental Engineering system and core components

Comments

@just-ero
Copy link

just-ero commented Feb 23, 2024

Description

As mentioned by @yufeih in #9717 (reply in thread), the use of NewtonSoft.Json in this library is due to the age of it. That's understandable.

However, using .NET's own System.Text.Json namespace should provide at least these obvious benefits:

  • Clear performance advantage.
  • One less third-party dependency.

I propose that a gradual move to System.Text.Json be made, despite it not being trivial. This move can coincide with the change to providing public config/options classes proposed in #9726.

Feel free to close if not planned or move to a "Backlog"-type milestone.

@yufeih yufeih added the fundamental Engineering system and core components label Feb 23, 2024
@yufeih
Copy link
Contributor

yufeih commented Feb 23, 2024

Thank you @just-ero for offering help! This is definitely something we are willing to accept as a contribution. We appreciate your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fundamental Engineering system and core components
Projects
None yet
Development

No branches or pull requests

2 participants