[Bug] Invalid Edit-this-page URL after update to docfx v2.72.0

[bkoelman]

Comparing the generated website with the output from 2.71.1:

1. Incorrect remote URL: "json-api-dotnet" changed to "verdie-g" (which is a fork of the project that I cloned a while ago)
2. Backslashes instead of forward slashes: "/api/index.md/#L1" changed to "\api\index.md/#L1"

Before update:

<meta name="docfx:docurl" content="https://github.com/json-api-dotnet/JsonApiDotNetCore/blob/master/docs/api/index.md/#L1">
...
<a href="https://github.com/json-api-dotnet/JsonApiDotNetCore/blob/master/docs/api/index.md/#L1" class="edit-link">Edit this page</a>

After update:

<meta name="docfx:docurl" content="https://github.com/verdie-g/JsonApiDotNetCore/blob/master/docs\api\index.md/#L1">
...
<a href="https://github.com/verdie-g/JsonApiDotNetCore/blob/master/docs\api\index.md/#L1" class="edit-link">Edit this page</a>

Context:

• OS: Windows
• Docfx version: 2.71.1

Output from git remote -v:

github-desktop-verdie-g https://github.com/verdie-g/JsonApiDotNetCore.git (fetch)
github-desktop-verdie-g https://github.com/verdie-g/JsonApiDotNetCore.git (push)
origin  https://github.com/json-api-dotnet/JsonApiDotNetCore.git (fetch)
origin  https://github.com/json-api-dotnet/JsonApiDotNetCore.git (push)

Output from git config --get remote.origin.url:

https://github.com/json-api-dotnet/JsonApiDotNetCore.git

[yufeih]

Seems to be a bug in GitReader.

[filzrev]

2. Backslashes instead of forward slashes: "/api/index.md/#L1" changed to "\api\index.md/#L1"

Mixed path separator char problems on Windows environment is still occurred on latest docfx version. (2.73.1)
It's seems not related to GitReader library.
But caused by following path strings concatenation.

docfx/src/Docfx.Common/Git/GitUtility.cs

Line 45 in d3a342c

Path = Path.GetRelativePath(repo.path, filePath),