Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Suppress Codecov indirect coverage changes reports #9067

Closed
filzrev opened this issue Aug 11, 2023 · 1 comment · Fixed by #9118
Closed

[Feature Request] Suppress Codecov indirect coverage changes reports #9067

filzrev opened this issue Aug 11, 2023 · 1 comment · Fixed by #9118
Labels
fundamental Engineering system and core components

Comments

@filzrev
Copy link
Contributor

filzrev commented Aug 11, 2023

Is your feature request related to a problem? Please describe.
When PR is created.
Codecov randomly reports indirect coverage changes.
relating to following two files.

Describe the solution you'd like

I can't determine what's cause these coverage problems on CI environment.
Simple solution is to add following attribute to methods that cause coverage diff.

[ExcludeFromCodeCoverage(Justification = "When running CI Build. Codecov report Indirect changes.")]

@yufeih yufeih added the fundamental Engineering system and core components label Aug 11, 2023
@filzrev
Copy link
Contributor Author

filzrev commented Aug 22, 2023

GitUtility.cs related indirect changes are suppressed by explicitly set ExcludeFromCodeCoverage.

ArrayDictionary.cs related indirect changes seems occurred by parallel execution.
If set maxParallelism to 1. This branch is not called.

On GitHub hosted runner. there are 2 CPU core. so race condition occurred occasionally.
On local environment. double-checked locking's lock wait is frequently occurs.
Thought it is not spend large lock-wait times. It might be better to optimize ArrayDictionary.cs code to lock-free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fundamental Engineering system and core components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants