Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize front end development flow #8281

Closed
3 tasks done
yufeih opened this issue Dec 17, 2022 · 5 comments · Fixed by #8422
Closed
3 tasks done

Modernize front end development flow #8281

yufeih opened this issue Dec 17, 2022 · 5 comments · Fixed by #8422
Labels
template The stock site template
Milestone

Comments

@yufeih
Copy link
Contributor

yufeih commented Dec 17, 2022

Modernize front end development flow to support:

  • Writing scripts using typescript and modules
  • Writing css using sass and modules
  • Template visual regression testing
@yufeih yufeih added this to the Backlog milestone Dec 17, 2022
@yufeih yufeih added the template The stock site template label Dec 17, 2022
@KalleOlaviNiemitalo
Copy link

Does this affect the third-party copyright notices that I need to publish on the generated websites? If the build involves transpiling, I fear it might become more difficult to find the copyright information.

@yufeih
Copy link
Contributor Author

yufeih commented Jan 22, 2023

Does this affect the third-party copyright notices that I need to publish on the generated websites? If the build involves transpiling, I fear it might become more difficult to find the copyright information.

Does the transpiled css and js files here works for you? You may find the license info at the end of the files in form of comments.

@KalleOlaviNiemitalo
Copy link

"here" points back to my comment; did you post the wrong link?

@yufeih
Copy link
Contributor Author

yufeih commented Jan 22, 2023

"here" points back to my comment; did you post the wrong link?

Oops, it is the docfx.json and docfx.css file here: https://github.com/docascode/template/tree/main/dist

@KalleOlaviNiemitalo
Copy link

The comments link to the MIT license text, but I'm not sure whether that counts as being "included" as stipulated in the clause:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template The stock site template
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants