Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Toc filter disappeared on 2.76 version #10011

Open
mikasoukhov opened this issue Jun 16, 2024 · 4 comments
Open

[Bug] Toc filter disappeared on 2.76 version #10011

mikasoukhov opened this issue Jun 16, 2024 · 4 comments
Labels
bug A bug to fix template The stock site template

Comments

@mikasoukhov
Copy link

On that configuration https://github.com/StockSharp/doc/blob/main/en/doc.json compiled by 2.75.3 works fine. After migration filtering panel (from left side) - disappeared. Is it a bug or there is need to do some more extra migration steps?

@mikasoukhov mikasoukhov added the bug A bug to fix label Jun 16, 2024
@filzrev
Copy link
Contributor

filzrev commented Jun 16, 2024

After migration filtering panel (from left side) - disappeared.

Is that mean left side TOC menu area?
In this case. that is caused by PR #9737.

As commented on above PR's comment.
It introduce BREAKING CHANGE to existing modern template user. (Not included at release note though)

To workaround this issue.
It need explicitly set _disableToc: false metadata to related pages. (By using fileMetadata)

@mikasoukhov
Copy link
Author

To workaround this issue. It need explicitly set _disableToc: false metadata to related pages. (By using fileMetadata)

Thanks. I will wait for the release in where it will be fixed.

@filzrev
Copy link
Contributor

filzrev commented Jun 18, 2024

Thanks. I will wait for the release in where it will be fixed.

This behavior is intentionally changed.
Its purpose is to fix inconsistent TOC visibility behavior between default/modern template.

So without additional Breaking Changes. (I've created [feature request] issue at #10021).
Current behavior is expected to continue.

@mikasoukhov
Copy link
Author

So without additional Breaking Changes. (I've created [feature request] issue at #10021). Current behavior is expected to continue.

I appreciate your detailed explanation regarding the intentional changes to the template behavior. However, I am not fully versed in all the intricacies related to the templates.

Wouldn't it be more efficient to fix the templates themselves to ensure consistent behavior, rather than introducing additional patches to the configuration? Ideally, configurations with default values should remain stable across versions, ensuring seamless updates. This approach would prevent the issue of outdated examples and encourage regular updates without the fear of breaking changes.

Consistency in template behavior without the need for extra configuration adjustments would lead to a more streamlined user experience.

Thank you for considering this perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug to fix template The stock site template
Projects
None yet
Development

No branches or pull requests

3 participants