Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResumeRuntime command to client library #1311

Closed
josalem opened this issue Jul 2, 2020 · 1 comment
Closed

Add ResumeRuntime command to client library #1311

josalem opened this issue Jul 2, 2020 · 1 comment
Assignees
Labels
documentation Documentation related issue enhancement New feature or request Microsoft.Diagnostics.NETCore.Client Priority:1 Work that is critical for the release, but we could probably ship without
Milestone

Comments

@josalem
Copy link
Contributor

josalem commented Jul 2, 2020

Update the documentation for the new Advertise protocol and implement the ResumeRuntime command on DiagnosticClient.

@josalem josalem added enhancement New feature or request documentation Documentation related issue Microsoft.Diagnostics.NETCore.Client Priority:1 Work that is critical for the release, but we could probably ship without labels Jul 2, 2020
@josalem josalem added this to the 5.0 milestone Jul 2, 2020
@josalem josalem self-assigned this Jul 2, 2020
@josalem
Copy link
Contributor Author

josalem commented Aug 11, 2020

Was added in #1303. Code can be found here:

internal void ResumeRuntime()
{
IpcMessage message = new IpcMessage(DiagnosticsServerCommandSet.Process, (byte)ProcessCommandId.ResumeRuntime);
var response = IpcClient.SendMessage(_endpoint, message);
switch ((DiagnosticsServerResponseId)response.Header.CommandId)
{
case DiagnosticsServerResponseId.Error:
// Try fallback for Preview 7 and Preview 8
ResumeRuntimeFallback();
//var hr = BitConverter.ToInt32(response.Payload, 0);
//throw new ServerErrorException($"Resume runtime failed (HRESULT: 0x{hr:X8})");
return;
case DiagnosticsServerResponseId.OK:
return;
default:
throw new ServerErrorException($"Resume runtime failed - server responded with unknown command");
}
}

@josalem josalem closed this as completed Aug 11, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation related issue enhancement New feature or request Microsoft.Diagnostics.NETCore.Client Priority:1 Work that is critical for the release, but we could probably ship without
Projects
None yet
Development

No branches or pull requests

1 participant