Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[3.1] Test-only followup for "Fix Unix named mutex crash during some race conditions" #42917

Closed
wants to merge 1 commit into from

Conversation

kouvel
Copy link
Member

@kouvel kouvel commented May 12, 2020

Test-only port of dotnet/runtime#36268 to 3.1
Test-only followup for and depends on dotnet/coreclr#28039

Closes dotnet/runtime#34271

…race conditions"

Test-only followup for and depends on ###
@kouvel kouvel added area-System.Threading * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) labels May 12, 2020
@kouvel kouvel added this to the 3.1.x milestone May 12, 2020
@kouvel kouvel requested a review from janvorli May 12, 2020 07:22
@kouvel kouvel self-assigned this May 12, 2020
@kouvel
Copy link
Member Author

kouvel commented May 12, 2020

Tests will likely fail until the dependency change flows into corefx, flagging as no-merge for now

@danmoseley danmoseley closed this Jul 6, 2020
@danmoseley danmoseley reopened this Jul 6, 2020
@danmoseley
Copy link
Member

Restarted CI

@danmoseley
Copy link
Member

@kouvel Windows all passes, but there is a segfault in Linux and Mac on x64 only.

@kouvel
Copy link
Member Author

kouvel commented Jul 6, 2020

dotnet/coreclr#28039 would have to be merged and flow into the corefx repo before the tests would pass, seg fault is expected until then, but not guaranteed (so keeping it flagged so no-merge for now).

@kouvel kouvel added * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) and removed * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) labels Jul 6, 2020
@danmoseley
Copy link
Member

@kouvel - oh, my bad. I just assumed that was merged. Does it make sense to close both PR's, until and unless you plan to move them forward?

@kouvel
Copy link
Member Author

kouvel commented Jul 7, 2020

The plan was to take it for 3.1, I don't think that has changed, but it's just waiting for an appropriate time, as it's not a critical one. I prefer to keep them open just so as not to lose track of the changes until it's decided that we don't want to take them for 3.1, though I don't feel strongly about issue closing / keeping-open either way.

@kouvel
Copy link
Member Author

kouvel commented Jul 7, 2020

CC @jeffschwMSFT

@danmoseley
Copy link
Member

Whatever works for you guys.

@kouvel
Copy link
Member Author

kouvel commented Dec 11, 2020

Dependency PR has been closed for now

@kouvel kouvel closed this Dec 11, 2020
@kouvel kouvel deleted the NamedMutexFixFx31 branch December 11, 2020 11:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Threading * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants