-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test coverage for System.Math
and System.MathF
should be expanded.
#19036
Comments
Anyone interested in taking this on? |
@AlexGhiondea If you want to assign it to me, I can work on this. |
Done, ping us here when you accept, then we can assign. |
@karelz done. |
@vcsjones just curious if you're still working on it ... |
@karelz Ah! Sorry this one fell off my radar. Yes I will get a PR in very soon. |
Great, no rush. I'm happy my nagging was useful at least once :) (to catch something accidentally dropped ;)) |
@vcsjones, are you still working on this? If not, I'm done with the other |
2.5 months no progress, I think it is safe to assume @vcsjones didn't have much time so far - feel free to grab it @tannergooding. |
Yes - I apologize. |
@vcsjones, I do the same thing sometimes (as happened when I created the bug in October up until today, when I actually had some time again 😄) |
Agreed, things happen, no worries @vcsjones ;-) |
Currently the test coverage for
System.Math
andSystem.MathF
is fairly sparse, to say the least.It should be expanded, at the very least, with the same set of tests that cover the native implementations in the CoreCLR PAL layer (which has a minimum of 20 tests per API and ensures that the interesting inputs are covered).
As part of this work, the tests should also be converted to use the
[Theory]
attribute.The text was updated successfully, but these errors were encountered: