Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage for System.Math and System.MathF should be expanded. #19036

Closed
tannergooding opened this issue Oct 20, 2016 · 13 comments · Fixed by dotnet/corefx#17217
Closed

Test coverage for System.Math and System.MathF should be expanded. #19036

tannergooding opened this issue Oct 20, 2016 · 13 comments · Fixed by dotnet/corefx#17217
Labels
area-System.Runtime help wanted [up-for-grabs] Good issue for external contributors test-enhancement Improvements of test source code
Milestone

Comments

@tannergooding
Copy link
Member

Currently the test coverage for System.Math and System.MathF is fairly sparse, to say the least.

It should be expanded, at the very least, with the same set of tests that cover the native implementations in the CoreCLR PAL layer (which has a minimum of 20 tests per API and ensures that the interesting inputs are covered).

As part of this work, the tests should also be converted to use the [Theory] attribute.

@AlexGhiondea
Copy link
Contributor

Anyone interested in taking this on?

@vcsjones
Copy link
Member

@AlexGhiondea If you want to assign it to me, I can work on this.

@AlexGhiondea
Copy link
Contributor

@karelz could you add @vcsjones to the contributor list?

@karelz
Copy link
Member

karelz commented Jan 4, 2017

Done, ping us here when you accept, then we can assign.

@vcsjones
Copy link
Member

vcsjones commented Jan 4, 2017

@karelz done.

@karelz
Copy link
Member

karelz commented Jan 29, 2017

@vcsjones just curious if you're still working on it ...

@vcsjones
Copy link
Member

@karelz Ah! Sorry this one fell off my radar. Yes I will get a PR in very soon.

@karelz
Copy link
Member

karelz commented Jan 30, 2017

Great, no rush. I'm happy my nagging was useful at least once :) (to catch something accidentally dropped ;))

@tannergooding
Copy link
Member Author

@vcsjones, are you still working on this? If not, I'm done with the other System.MathF bugs I had self-assigned and can start on this again.

@karelz
Copy link
Member

karelz commented Mar 16, 2017

2.5 months no progress, I think it is safe to assume @vcsjones didn't have much time so far - feel free to grab it @tannergooding.

@vcsjones
Copy link
Member

Yes - I apologize. ☹️

@tannergooding
Copy link
Member Author

@vcsjones, I do the same thing sometimes (as happened when I created the bug in October up until today, when I actually had some time again 😄)

@karelz
Copy link
Member

karelz commented Mar 17, 2017

Agreed, things happen, no worries @vcsjones ;-)

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime help wanted [up-for-grabs] Good issue for external contributors test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants