This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Prevent loading byref-like types with invalid layout #25200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc @sergiy-k |
MichalStrehovsky
added a commit
to MichalStrehovsky/corert
that referenced
this pull request
Jul 3, 2019
MichalStrehovsky
added a commit
to dotnet/corert
that referenced
this pull request
Jul 3, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…25200) First approximation of a fix for dotnet/coreclr#25057. This has two problems: * We're checking for any byref-like typed fields. Types that don't actually contain interior pointers but were marked as `ref struct` will fail to load when not aligned properly. * We're not doing the deep validation that we do for reference types to make sure the `ByReference<T>` field doesn't overlap with another non-byreference field. Question is whether we're okay with those limitations, or whether we need a better fix. Better fix would likely entail inefficiently walking over the fields à la `FindByRefPointerOffsetsInByRefLikeObject` (doing the more efficient thing that we do for object references below would require a GCDesc representation of byrefness). Contributes to dotnet/coreclr#25057. Commit migrated from dotnet/coreclr@84dc373
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First approximation of a fix for #25057.
This has two problems:
ref structwill fail to load when not aligned properly.ByReference<T>field doesn't overlap with another non-byreference field.Question is whether we're okay with those limitations, or whether we need a better fix. Better fix would likely entail inefficiently walking over the fields à la
FindByRefPointerOffsetsInByRefLikeObject(doing the more efficient thing that we do for object references below would require a GCDesc representation of byrefness).Contributes to #25057.