This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix explicit constructor calls and Remove multi-line comments #23162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franksinankaya
changed the title
|
cc @dotnet/jit-contrib |
franksinankaya
force-pushed
the
gcc_cleanup_10
branch
2 times, most recently
from
49febc3 to
fb813be
Compare
am11
reviewed
Mar 10, 2019
franksinankaya
force-pushed
the
gcc_cleanup_10
branch
5 times, most recently
from
7bf6b4a to
f668cce
Compare
janvorli
reviewed
Mar 11, 2019
franksinankaya
force-pushed
the
gcc_cleanup_10
branch
12 times, most recently
from
03ed09c to
f3b1eda
Compare
BruceForstall
suggested changes
Mar 14, 2019
franksinankaya
force-pushed
the
gcc_cleanup_10
branch
from
f3b1eda to
3580cc1
Compare
|
unrelated compilation error on arm: 19:59:53 [ 26%] Built target FromNativePaths_lib let me rebase one more time. |
franksinankaya
force-pushed
the
gcc_cleanup_10
branch
from
3580cc1 to
fa4a819
Compare
franksinankaya
commented
Mar 15, 2019
franksinankaya
force-pushed
the
gcc_cleanup_10
branch
from
fa4a819 to
da9422e
Compare
franksinankaya
force-pushed
the
gcc_cleanup_10
branch
from
da9422e to
d6d0d72
Compare
|
Is this good to go in? |
franksinankaya
force-pushed
the
gcc_cleanup_10
branch
from
6881a72 to
fe25f35
Compare
franksinankaya
force-pushed
the
gcc_cleanup_10
branch
2 times, most recently
from
f0ef607 to
ef6e009
Compare
franksinankaya
force-pushed
the
gcc_cleanup_10
branch
from
ef6e009 to
a1a0160
Compare
|
@dotnet-bot retest Windows_NT x64 Checked CoreFX Tests |
|
@BruceForstall : can you review the newer version? |
BruceForstall
approved these changes
Mar 18, 2019
sandreenko
pushed a commit
to sandreenko/coreclr
that referenced
this pull request
Mar 18, 2019
…#23162) * fix implicit constructor call * extern c format patch * muti-line * Remove direct constructor call * Conversion * Need paranthesis * Return value on resize * declspec(Thread) * Ignore warnings for GCC * Formatting issues * Move cast to constant
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…/coreclr#23162) * fix implicit constructor call * extern c format patch * muti-line * Remove direct constructor call * Conversion * Need paranthesis * Return value on resize * declspec(Thread) * Ignore warnings for GCC * Formatting issues * Move cast to constant Commit migrated from dotnet/coreclr@6100a9f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.