dotnet restore returns invalid error code

[delanym]

I'm doing a container build with mcr.microsoft.com/dotnet/core/sdk:3.1.201 and package restore regularly times out.

dotnet restore should fail if any packages fail to download and exit with an error code so I know to stop trying to build. If --ignore-failed-sources is set only then exit with 0.

[carlossanlop]

@MichaelSimons any chance you could take a look?

[MichaelSimons]

@delanym - Can you share your repo steps? Is this utilizing a Dockerfile?

@carlossanlop - this may be a better question for the NuGet folks.

[delanym]

@MichaelSimons

/tmp # sudo docker run -it mcr.microsoft.com/dotnet/core/sdk:3.1.201
root@fda3f4b9b68a:/# dotnet restore
Failed to download package 'Microsoft.AspNetCore.Antiforgery.2.2.0' from 'https://api.nuget.org/v3-flatcontainer/microsoft.aspnetcore.antiforgery/2.2.0/microsoft.aspnetcore.antiforgery.2.2.0.nupkg'.
The download of 'https://api.nuget.org/v3-flatcontainer/microsoft.aspnetcore.antiforgery/2.2.0/microsoft.aspnetcore.antiforgery.2.2.0.nupkg' timed out because no data was received for 60000ms.
Exception of type 'System.TimeoutException' was thrown.
Restore completed in 2.78 min for /MvcWebFront.csproj.
Restore completed in 2.97 min for /MvcWebFront.csproj.
root@fda3f4b9b68a:/# echo $?
0
root@fda3f4b9b68a:/#

Before running dotnet restore, copy the attached csproj file:
dkr cp ./webapps_webinterfacewebapp/src/main/cs/MvcWebFront/MvcWebFront.csproj fda3f4b9b68a:/

MvcWebFront.csproj.txt

[delanym]

Any luck here? I can't create a reliable build system because dotnet restore pretends to succeed.

[carlossanlop]

Per @MichaelSimons suggestion, pinging @rrelyea from the nuget team to help.

[rrelyea]

Perhaps related to: dotnet/msbuild#1603

If that doesn’t help, please engage with team in issues at nuget/home

[delanym]

I will do that. However, lets not confuse the issue here. This dotnet application returns 0 even though packages failed to download. If it was getting packages from nuget directly, or a faulty mirror, or some custom proxy, it shouldn't matter. This is a basic requirement and its not working!

The option to --ignore-failed-sources is not actually an option, its the default behaviour. It should be changed to an option, please.

[delanym]

bump