Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Core 2.1.6 #2053

Closed
leecow opened this issue Nov 13, 2018 · 11 comments
Closed

.NET Core 2.1.6 #2053

leecow opened this issue Nov 13, 2018 · 11 comments

Comments

@leecow
Copy link
Member

leecow commented Nov 13, 2018

November 2018 .NET Updates

The following .NET updates were released in November 2018. This issue will be updated if there are any additional releases during the month.

.NET Core

A discussion issue is available for questions or feedback about this release.

.NET Support Policies

Microsoft support policies are defined in the following documents:

Previous Updates

@yaakov-h
Copy link
Member

@leecow the October link is broken in the related Announcements issue.

@karelz
Copy link
Member

karelz commented Nov 13, 2018

@yaakov-h thanks! Fixed.

@jarz
Copy link

jarz commented Nov 14, 2018

I'm unable to restore an internal NuGet package from Azure DevOps Artifacts with SDK 2.1.500, but SDK 2.1.403 works. Should I create an issue here or in another repo?

@karelz
Copy link
Member

karelz commented Nov 14, 2018

@jarz it does not seem to be related to 2.1.6, so not on this issue.
Try to narrow down what triggers the problem - is it your environment? (Azure DevOps Artifacts - whatever that is) Or is it reproducible under some circumstances everywhere? If it is not specific problem of the environment, then this repo is a good start.

@megafinz
Copy link

Seems like after update to 2.1.6 our CI silently stopped running unit tests with the following message:

Skipping running test for project <ProjectPathAndName>. To run tests with dotnet test add "<IsTestProject>true<IsTestProject>" property to project file.

CI pulled the following docker image when tests stopped working (it was on November 13th):

Pulling docker image microsoft/dotnet:2.1-sdk ...
Using docker image sha256:732ac6c02e837b14d3ff36f5b2e3d732a7a52c029e489e1ba905996ddf05f358 for microsoft/dotnet:2.1-sdk ...

Previous image doesn't seem to have this behavior, tests worked fine:

Using docker image sha256:6baac5bd0ea2ec449a4643e27d701ce06f8d2b2bc2b150a425c59015e5204dc3 for microsoft/dotnet:2.1-sdk ...

@karelz
Copy link
Member

karelz commented Nov 16, 2018

@megafinz is that output from msbuild? Are you able to track down what triggers it?
@nguerrera @dsplaisted can you please help route it?

@dsplaisted
Copy link
Member

@megafinz Can you file an issue in https://github.com/microsoft/vstest with as much information as possible?

@joeaudette
Copy link

fyi, broken link for release notes here: https://www.microsoft.com/net/download

@karelz
Copy link
Member

karelz commented Nov 16, 2018

@joeaudette thanks! I merged your report with #2062 (same problem on another subpage)

@megafinz
Copy link

@karelz @dsplaisted I was trying to find a repro but had no luck. I believe new version of SDK ignores unit test project that have no IsTestProject property set to true. This property is set either explicitly in project file or by referencing Microsoft.NET.Test.Sdk package (which we do reference actually). I discovered that if this package is not present on disk when tests are run, then the aforementioned message appears and tests are skipped. So I believe our problem is caused by some issue with our CI, which was masked by previous SDK still running tests in projects that are not actually marked by IsTestProject.

vany0114 added a commit to vany0114/EF.DbContextFactory that referenced this issue Dec 17, 2018
@leecow
Copy link
Member Author

leecow commented Jan 29, 2019

Closing older release. If there are pending discussions, please keep them going in the 2.1.7 issue

@leecow leecow closed this as completed Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants