This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two additional rules for dealing with attributes:
Removing superfluous parentheses
It's conventional to omit parentheses when the attribute doesn't take any arguments, for example:
becomes
Separating attribute lists
Most folks only use a single attribute in an attribute list, although the syntax supports multiple attributes. In most cases, putting attributes in separate lists is beneficial because it improves readability and allows better diffs.
This changes code like this:
to
The only exception are attributes for parameters. In interop code, it's quite common to mark parameters with
[In]
and[Out]
. Since the attributes are usually written inline, i.e. not on separate lines, it's actually beneficial to no split them into separate lists.This means that code like this is left as-is: