Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Fixes the file descriptor issue during restore on OSX #818

Merged
merged 1 commit into from
Jan 13, 2016

Conversation

livarcocc
Copy link

Increases the number of file descriptors available to the process in order to hit a issue when doing restore where we were running out of file descriptors during the build.

@brthor
Copy link

brthor commented Jan 13, 2016

:shipit:

@livarcocc
Copy link
Author

@dotnet-bot Test CentOS7.1 Release Build please

@@ -24,6 +24,9 @@ header "Checking Pre-Reqs"

$REPOROOT/scripts/test/check-prereqs.sh

# Increases the file descriptors limit for this bash. It prevents an issue we were hitting during restore
ulimit -n 512

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

…order to hit a issue when doing restore where we were running out of file descriptors during the build.
@livarcocc livarcocc force-pushed the file_descriptor_limit branch from 030c488 to 9994b6b Compare January 13, 2016 21:40
@brthor
Copy link

brthor commented Jan 13, 2016

LGTM

livarcocc pushed a commit that referenced this pull request Jan 13, 2016
Fixes the file descriptor issue during restore on OSX
@livarcocc livarcocc merged commit 2417f50 into dotnet:master Jan 13, 2016
@livarcocc livarcocc deleted the file_descriptor_limit branch January 20, 2016 23:45
@andyleejordan
Copy link
Member

I think we need to bump it more, while ulimit -n 512 helped (it didn't crash immediately), as it recurses there are still too many open files for my project.

@andyleejordan
Copy link
Member

FWIW 1024 seemed enough.

@andyleejordan
Copy link
Member

Ah, I see this is only for the build of CLI. Is there anything we can do for users? I don't want to have to wrap dotnet restore in a script to bump the file limit.

@moozzyk
Copy link

moozzyk commented Jan 22, 2016

@andschwa I think @zhili1208 is fixing "too many open files" during dotnet restore on Mac OS

@andyleejordan
Copy link
Member

Ah, sweet. Thanks @moozzyk!

wli3 pushed a commit to wli3/cli that referenced this pull request Jul 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants