From c87ddeff953ed7e4099ca8cc07937b461414fe4c Mon Sep 17 00:00:00 2001 From: Jose Perez Rodriguez Date: Fri, 18 Sep 2015 11:11:07 -0700 Subject: [PATCH] Fixing comment since we are now includding only the nested types that are visible outside the assembly. --- src/GenFacades/Program.cs | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/GenFacades/Program.cs b/src/GenFacades/Program.cs index a7992d5592..2c7d57096f 100644 --- a/src/GenFacades/Program.cs +++ b/src/GenFacades/Program.cs @@ -485,12 +485,7 @@ private void AddTypeForward(Assembly assembly, INamedTypeDefinition seedType) assembly.ExportedTypes = new List(); assembly.ExportedTypes.Add(alias); - // Recursively add forwarders for all nested types regardless of their accessibility. This is - // how the C# compiler emits type forwarders for nested types. We might not need them for - // nested types that are not visible outside the assembly, but it is safer to replicate how - // the C# compiler works. Plus, it helps when diffing the output from ildasm for facades - // that were built from source vs. those that were produced by this tool. - // + // Recursively add forwarders only for the nested types that are accessible outside of the assembly. // NOTE: Some design-time tools can resolve forwarded nested types with only the top-level forwarder, // but the runtime currently throws a TypeLoadException without explicit forwarders for the nested // types.