Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ChunkedMessageBody be a facade over the Connection Pipe and remove the RequestPipe #7605

Open
jkotalik opened this issue Feb 15, 2019 · 3 comments
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-kestrel feature-pipelines Anything relating to exposing/using Pipes in ASP.NET Core Perf severity-nice-to-have This label is used by an internal tool
Milestone

Comments

@jkotalik
Copy link
Contributor

#7603 will keep a request pipe when doing chunked request reading. This CAN be removed, but was too large/out of scope to be in the same PR.

@jkotalik jkotalik added enhancement This issue represents an ask for new feature or an enhancement to an existing one Perf cost: M feature-kestrel labels Feb 15, 2019
@jkotalik jkotalik modified the milestones: 3.0.0-preview5, Backlog Feb 21, 2019
@jkotalik jkotalik added the feature-pipelines Anything relating to exposing/using Pipes in ASP.NET Core label Feb 22, 2019
@pranavkm pranavkm removed the cost: M label Nov 6, 2020
@jkotalik jkotalik added affected-very-few This issue impacts very few customers severity-nice-to-have This label is used by an internal tool labels Nov 13, 2020 — with ASP.NET Core Issue Ranking
@davidfowl
Copy link
Member

This is one we should do but before we do it, we should write some performance tests. I'm guessing chunked reads aren't great but I could be wrong. Another alternative here might be to reuse pipe implementations since these ones are short lived.

@ghost
Copy link

ghost commented Apr 2, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost
Copy link

ghost commented Aug 11, 2021

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-kestrel feature-pipelines Anything relating to exposing/using Pipes in ASP.NET Core Perf severity-nice-to-have This label is used by an internal tool
Projects
None yet
Development

No branches or pull requests

5 participants