Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port fix for #6102 to 2.2.2 #6543

Closed
rynowak opened this issue Jan 9, 2019 · 2 comments
Closed

Port fix for #6102 to 2.2.2 #6543

rynowak opened this issue Jan 9, 2019 · 2 comments
Assignees
@rynowak
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed
Milestone
2.2.2

Comments

@rynowak
Copy link
Member

rynowak commented Jan 9, 2019

We should patch #6102 for 2.2.2. This issue can cause intensive CPU and memory consumption when pages are recompiled or the route table is updated. This issue gets worse each time a page is recompiled, leading to growth in resource consumption and then eventually thread pool starvation or OOM and crash.

We know that many users use the recompilation features of MVC in production, so this is not limited to developer inner loop scenarios.
@rynowak rynowak added this to the 2.2.2 milestone Jan 9, 2019
@rynowak rynowak self-assigned this Jan 9, 2019
@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jan 10, 2019
@rynowak
Copy link
Member Author

rynowak commented Jan 14, 2019

The PR to port the fix is: #6658

@rynowak rynowak mentioned this issue Jan 14, 2019
Merged
@rynowak
Copy link
Member Author

rynowak commented Jan 16, 2019

Done.

@rynowak rynowak closed this as completed Jan 16, 2019
@rynowak rynowak added the Done This issue has been fixed label Jan 16, 2019
@Leon99 Leon99 mentioned this issue Mar 28, 2019
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rynowak rynowak

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed
Projects
None yet
Milestone
2.2.2
Development

No branches or pull requests
2 participants
@Eilon @rynowak