Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WsFederation Wtrealm is required but it is a nullable string on WsFederationOptions #50242

Open
eerhardt opened this issue Aug 21, 2023 · 3 comments
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Milestone

Comments

@eerhardt
Copy link
Member

          @halter73 @Tratcher - any thoughts here? Why is `Options.Wtrealm` annotated as `string?` when `WsFederationMessage.Wtrealm` is a non-nullable `string`? Do we have our nullable annotations incorrect in ASP.NET?

Originally posted by @eerhardt in #50218 (comment)

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Aug 21, 2023
@halter73
Copy link
Member

Should we close this now that AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#2240 has been opened?

@eerhardt
Copy link
Member Author

I think we can use this to track removing the !s added in #50218. All three of them should be able to be removed once we get a build with AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#2241 in it.

@SteveSandersonMS SteveSandersonMS added this to the Backlog milestone Aug 24, 2023
@ghost
Copy link

ghost commented Aug 24, 2023

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Development

No branches or pull requests

4 participants