Use SearchValues throughout dotnet/aspnetcore

[MihaZupan]

Akin to dotnet/runtime#78204

Some uses have already been replaced in #45300, but there are more cases where using IndexOfAnyValues can speed things up or simplify the implementation. From a few grep searches:

• PathString.ToUriComponent can be rewritten along the lines of UriHelper.EscapeString

• aspnetcore/src/Http/Http.Abstractions/src/HostString.cs

  Line 120 in 83237c9

  public string ToUriComponent()

• aspnetcore/src/FileProviders/Embedded/src/Manifest/EmbeddedFilesManifest.cs

  Line 87 in 83237c9

  private static bool HasInvalidPathChars(string path) => path.IndexOfAny(_invalidFileNameChars) != -1;

  Targets old TFMs

• aspnetcore/src/Shared/MediaType/HttpTokenParsingRule.cs

  Line 69 in 83237c9

  internal static int GetTokenLength(string input, int startIndex)

• aspnetcore/src/Http/Shared/HttpRuleParser.cs

  Line 94 in 83237c9

  internal static int GetTokenLength(StringSegment input, int startIndex)

  (which looks like a copy of the one in Runtime, so could just copy Use IndexOfAnyValues in System.Net.Http runtime#78660)
• All the checks in https://github.com/dotnet/aspnetcore/blob/main/src/Middleware/HttpOverrides/src/ForwardedHeadersMiddleware.cs

• aspnetcore/src/Http/Headers/src/ContentDispositionHeaderValue.cs

  Line 613 in 83237c9

  private static string Encode5987(StringSegment input)

  (also already done in runtime in Use IndexOfAnyValues in System.Net.Http runtime#78660)

• aspnetcore/src/Http/Shared/CookieHeaderParserShared.cs

  Line 238 in 83237c9

  private static bool IsCookieValueChar(char c)

• aspnetcore/src/Mvc/Mvc.ViewFeatures/src/Rendering/TagBuilder.cs

  Line 428 in 83237c9

  private static class Html401IdUtil

• aspnetcore/src/Mvc/Mvc.Razor/src/TagHelpers/UrlResolutionTagHelper.cs

  Line 52 in 83237c9

  private static readonly char[] ValidAttributeWhitespaceChars =

[adityamandaleeka]

Some of this was done. Moving to preview 4 to continue chipping away.

[ghost]

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

[gfoidl]

Nit: should the title of this issue be updated to use SearchValues (as IndexOfAnyValues got renamed)?

[madhub]

Should SearchValues also be used in MultipartReaderStream to find the boundary in the multipart parser

[ladeak]

I'd be interested in picking up a few items in the coming weeks.

[ladeak]

I think with the last PR everything outlined above is covered., hence the lát PR closed this issue.

[amcasey]

I think with the last PR everything outlined above is covered., hence the lát PR closed this issue.

Works for me. Any remaining concerns @MihaZupan?

[MihaZupan]

aspnetcore/src/Http/Headers/src/ContentDispositionHeaderValue.cs

Line 618 in 79ef5e3

private static string Encode5987(StringSegment input)

(see similar code in dotnet/runtime) looks like the only remaining place from my initial list, but I don't think we need to keep the issue open for that.

Thank you for the help @ladeak

[ladeak]

Ah, I missed that. I will do the final PR.