Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ActivityTracking in CreateDefaultBuilder #21966

Closed
shirhatti opened this issue May 18, 2020 · 0 comments · Fixed by #22376
Closed

Enable ActivityTracking in CreateDefaultBuilder #21966

shirhatti opened this issue May 18, 2020 · 0 comments · Fixed by #22376
Assignees
@shirhatti
Labels
area-hosting Includes Hosting area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Milestone
5.0.0-preview7

Comments

@shirhatti
Copy link
Contributor

dotnet/runtime#34305 is introducing new API on LoggerFactoryOptions to enable Activity tracking. We should enable it in CreateDefaultBuilder.

Needs to happen with- #21020
@shirhatti shirhatti added blocked The work on this issue is blocked due to some dependency area-hosting labels May 18, 2020
@shirhatti shirhatti added this to the Next sprint planning milestone May 18, 2020
@shirhatti shirhatti removed the blocked The work on this issue is blocked due to some dependency label May 29, 2020
@shirhatti shirhatti self-assigned this May 29, 2020
@shirhatti shirhatti linked a pull request Jun 3, 2020 that will close this issue
Use implicit logging scope for Activity #22376
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jul 24, 2020
@amcasey amcasey added the area-hosting Includes Hosting label Jun 1, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shirhatti shirhatti

Labels
area-hosting Includes Hosting area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
5.0.0-preview7
Development

Successfully merging a pull request may close this issue.

Use implicit logging scope for Activity dotnet/aspnetcore
4 participants
@JunTaoLuo @shirhatti @BrennanConroy @amcasey