Too many ISystemClock definitions

[YohDeadfall]

The ISystemClock defines a way to get the current time in UTC timezone, and it has a simple implementation:

public interface ISystemClock
{
    DateTimeOffset UtcNow { get; }
}

public interface SystemClock : ISystemClock
{
    public DateTimeOffset UtcNow => DateTimeOffset.UtcNow;
}

The interface exists in:

• Microsoft.AspNetCore.Authentication
• Microsoft.AspNetCore.ResponseCaching
• Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure
• Microsoft.Extensions.Internal

There is a small difference exists between implementations, but in most cases it can be moved out. In case of Kestrel's clock which has a specific logic inside, there could be made a new interface IScopedSystemClock which will provide the scope start time as UtcNow does now. Therefore, looks like all of them could be merged into a single class/interface and put into Microsoft.Extensions.Primitives.

[ghost]

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

[JunTaoLuo]

ISystemClock seems to be used elsewhere in our codebase as well so the list might be incomplete. Instead of putting this Extensions.Primitives, we should also consider having it as a shared source file.

[BrennanConroy]

We aren't planning to do anything here.