-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Tracing for RabbitMQ Component when we move to their v7 #562
Comments
Moving into preview milestone @eerhardt |
Moving to backlog, as RabbitMQ doesn't have a stable v7 package yet. We can do this when we update for the v7 version. |
Is there a new package yet? |
https://www.nuget.org/packages/RabbitMQ.Client/ Latest version is 7.0.0-rc.9 |
Trying to get tracing from the |
It is not supported in the v6.x versions of RabbitMQ.Client. It was implemented in rabbitmq/rabbitmq-dotnet-client#1261, which was merged into the v7 branch. v7 hasn't released stable yet. |
Once we have a build of RabbitMQ.Client with rabbitmq/rabbitmq-dotnet-client#1261, we will need to enable and document the "RabbitMQ.Client" ActivitySource for our component.
One thing to note is that we added our own ActivitySource for the connection retries we do:
aspire/src/Components/Aspire.RabbitMQ.Client/AspireRabbitMQExtensions.cs
Lines 23 to 24 in 4032b57
We should think about how to rectify the 2 activity sources in the future. One possibility is that once open-telemetry/semantic-conventions#454 is completed, we might not need our own ActivitySource for tracing the connection tries.
The text was updated successfully, but these errors were encountered: