-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split WithVolumeMount into two seperate methods #1437
Comments
What if the volume path for every aspire component had a default value for each resource (redis, postgres, rabbitmq, etc...)? And, you would only need to specify the name by default and the path was an optional parameter. With the approach that I am describing, the devs wouldn't need to look and figure out the volume path for containers but could change it if they wanted to. builder.addPostgresContainer().withvolumemount("postgresVolume"); builder.addRabbitmqContainer().withvolumemount("rabbitmqVolume"); builder.addrediscache().withvolumemount("rabbitmqVolume", ""); |
@josephaw1022 I think you are describing #837 |
@stbau04 You're right. I misread it initially. |
I'm exploring adding volumes as a first class resource to the Aspire application model. it still needs work so input is welcome. |
@mitchdenny, I think that would be interesting. I am curious exactly that would mean? Do you mean having them be independent of container creation and having more 1-1 mapping of methods to volume functionality? Or do you have something else in mind? Not related in the sense that it's not directly related to volumes specifically, but I do think it relates to this |
Probably we should wait for #1521 and then see if this is still necessary |
Tagging for offsite because we need to figure out what we are doing in the app model around volumes and how that translates to deployment. |
WithVolumeMount is mixing two different concepts: named volumes and bind mounts. They should probably be seperated into two methods.
Mentioned in #1132 and #837
Suggestion for usage:
The text was updated successfully, but these errors were encountered: