Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change copy icon to tick after click #1386

Closed
JamesNK opened this issue Dec 14, 2023 · 0 comments · Fixed by #1404
Closed

Change copy icon to tick after click #1386

JamesNK opened this issue Dec 14, 2023 · 0 comments · Fixed by #1404
Assignees
@JamesNK
Labels
area-dashboard
Milestone
preview 3 (Feb)

Comments

@JamesNK
Copy link
Member

JamesNK commented Dec 14, 2023

It's common to change the copy button to a tick for a short time after a click. This provides more feedback that the value was successfully copies. Should update copy buttons throughout the dashboard to do this.

See https://github.com/dotnet/aspire/pull/1332/files for an example:
copy-button-tick
@JamesNK JamesNK self-assigned this Dec 15, 2023
@JamesNK JamesNK added this to the preview 3 (Jan) milestone Dec 15, 2023
@JamesNK JamesNK removed the untriaged label Dec 15, 2023
@JamesNK JamesNK mentioned this issue Jan 11, 2024
Merged
@JamesNK JamesNK closed this as completed Jan 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JamesNK JamesNK

Labels
area-dashboard
Projects
None yet
Milestone
preview 3 (Feb)
Development

Successfully merging a pull request may close this issue.

Successfully copying changes the icon to a tick dotnet/aspire
1 participant
@JamesNK