Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetupNugetSources.ps1 should help out public builds #5233

Closed
1 of 2 tasks
mmitche opened this issue Apr 9, 2020 · 1 comment
Closed
1 of 2 tasks

SetupNugetSources.ps1 should help out public builds #5233

mmitche opened this issue Apr 9, 2020 · 1 comment

Comments

@mmitche
Copy link
Member

mmitche commented Apr 9, 2020

  • This issue is blocking
  • This issue is causing unreasonable pain

Right now SetupNugetSources.ps1 setup private credentials for internal feeds when called. This is all gravy. Unfortunately, internal feeds can sometimes show up in public nuget configs. On release day of an internal build, for instance. Because we can't access these feeds in public dnceng, restores will fail (aside: Nuget covers fixing this in nuget). SetupNugetSources.ps1 should remove these feeds when running on the public projects.

To do this:

  1. Change SetupNugetSources.ps1 to take a parameter IsInternalBuild or something along those lines.
  2. Change calls to SetupNugetSources.ps1 so that they always run, and pass the appropriate parameter for the internal build flag.
  3. If internal, behave as we do today (add feeds)
  4. If public, remove any internal feeds.
@mmitche
Copy link
Member Author

mmitche commented Aug 5, 2020

Closing in favor of #5890

@mmitche mmitche closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant