Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add msquic to Centos 7 Helix queue #12540

Closed
wfurt opened this issue Feb 11, 2023 · 12 comments
Closed

add msquic to Centos 7 Helix queue #12540

wfurt opened this issue Feb 11, 2023 · 12 comments
Assignees
Labels
Ops - Compliance First-responder-style issues handled by the Operations V-Team due to prioritization or urgency level

Comments

@wfurt
Copy link
Member

wfurt commented Feb 11, 2023

This is follow-up on #10253 (comment)

// from https://engdata.kusto.windows.net
WorkItems
| where JobName in (
"6a1d3b91-f1ae-40a3-8725-0bb3f45d793b", // Centos 7 doesn't work
"fb4186a2-dded-4c9a-8ba7-20314b96acb0", // RHEL7 good
"fe8209d6-d1a3-4a47-b534-2a057ac3aae9", // SLES 12 good
"81f9f8ee-4058-453e-8f82-8d061f46521b", // SLES 15 good
"d00bf0eb-14d0-4f47-b59f-c5048a5f144d", // Ubuntu 16.04 doesn't work
"adcf6c0b-1044-4dde-ada2-5c6137d01b0f", // Ubuntu 18.04 good
"469631c7-3f8a-46f5-ae21-5bf43e44b060", // Ubuntu 20.04 is good
"963594b0-7a9a-4d04-97cc-6735a67e8e10") // Ubuntu 22.04 is good
| where Name != JobName

I don't know if it is just time lapse, but it should be possible now. see dotnet/dotnet-buildtools-prereqs-docker#800 for detail.

openssl11 needed my msquic comes from EPEL repo. So it needs to be added if it is not already there.

cc: @ManickaP @CarnaViire @MattGal

@MattGal
Copy link
Member

MattGal commented Feb 13, 2023

@wfurt given you have the linked PR open, is this a request to add it to our non-docker images, or just a tracking issue about doing the work to support it in docker?

@wfurt
Copy link
Member Author

wfurt commented Feb 14, 2023

We also have test runs in full Helix queue and it is part of the hunt for complete coverage.
So yes, this is request to add it to non-docker images unless we decided to abandon it in runtime ci (and for example jump to 9)
In practice, this may be blocked on microsoft/msquic#3422.

@MattGal
Copy link
Member

MattGal commented Feb 14, 2023

OK, tossing on FROps backlog.

@MattGal MattGal added the Ops - Compliance First-responder-style issues handled by the Operations V-Team due to prioritization or urgency level label Feb 14, 2023
@MattGal
Copy link
Member

MattGal commented Feb 21, 2023

With microsoft/msquic#3422 still open and the suggested fix not merged, I am checking with @wfurt about this this morning.

@MattGal
Copy link
Member

MattGal commented Feb 21, 2023

Chatted with @wfurt today.

The work in the helix machines repo is already done. That is, we already install libmsquic from the Microsoft package source on all Centos 7 images, and routinely update the base images from Azure.

Every time this base image update happens, whatever is on the Microsoft package feed source is fetched and installed, so whenever this is updated our existing processes will address the issue. As we don't want to introduce building from source into the plain helix images, there is no work for DncEng to do here, so I am closing the issue.

@MattGal MattGal closed this as completed Feb 21, 2023
@wfurt
Copy link
Member Author

wfurt commented Feb 22, 2023

I check the Helix repro machine and looks good.

[toweinfu@toweinfu-c7 ~]$ rpm -qa| grep quic
libmsquic-2.1.7-1.x86_64

so it is on auto-update and it will pick up fixes when ready. It was not clear to me from the original description.
I think we will need to wait for MsQuic to roll-out next release with fix.

@wfurt
Copy link
Member Author

wfurt commented Feb 22, 2023

We generally need to do

$ sudo yum install epel-release
$ sudo yum install openssl11-libs

@MattGal
Copy link
Member

MattGal commented Feb 22, 2023

Cheap to add, reopening and I'll add that.

@MattGal MattGal reopened this Feb 22, 2023
@wfurt
Copy link
Member Author

wfurt commented Feb 22, 2023

Thanks @MattGal. We will also need fix from MsQuic but since the Queue is on regular updates we will just need to wait.

@MattGal
Copy link
Member

MattGal commented Feb 27, 2023

should be handled by https://dev.azure.com/dnceng/internal/_git/dotnet-helix-machines/pullrequest/29760, rolling out this week

@MattGal MattGal self-assigned this Feb 27, 2023
@MattGal
Copy link
Member

MattGal commented Mar 1, 2023

This rolled out today. If you continue to have issues with Centos.7 images please ping dnceng.

@MattGal MattGal closed this as completed Mar 1, 2023
@wfurt
Copy link
Member Author

wfurt commented Mar 2, 2023

thanks @MattGal for quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ops - Compliance First-responder-style issues handled by the Operations V-Team due to prioritization or urgency level
Projects
None yet
Development

No branches or pull requests

2 participants