Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build analysis generates duplicate reports #11211

Closed
1 of 3 tasks
jkotas opened this issue Oct 10, 2022 · 5 comments
Closed
1 of 3 tasks

Build analysis generates duplicate reports #11211

jkotas opened this issue Oct 10, 2022 · 5 comments
Assignees

Comments

@jkotas
Copy link
Member

jkotas commented Oct 10, 2022

The tables with hit statistics included in issues are duplicated. It is regression introduced in last few days.

Example from dotnet/runtime#76826:

Report

Build Definition Step Name Console log Pull Request
45431 dotnet/runtime Send to Helix Log dotnet/runtime#76764
45701 dotnet/runtime Send to Helix Log dotnet/runtime#76799
Build Definition Test Pull Request
45431 dotnet/runtime LibraryImportGenerator.UnitTests.IncrementalGenerationTests.GeneratorRun_WithNewCompilation_DoesNotKeepOldCompilationAlive dotnet/runtime#76764
45701 dotnet/runtime LibraryImportGenerator.UnitTests.IncrementalGenerationTests.GeneratorRun_WithNewCompilation_DoesNotKeepOldCompilationAlive dotnet/runtime#76799

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
4 4 4

Release Note Category

  • Feature changes/additions
  • Bug fixes
  • Internal Infrastructure Improvements

Release Note Description

Remove duplicated Known Issues matches from issue report

@jkotas
Copy link
Member Author

jkotas commented Oct 10, 2022

cc @markwilkie @missymessa

@missymessa
Copy link
Member

cc @ulisesh

@ulisesh
Copy link
Contributor

ulisesh commented Oct 11, 2022

This happens because we find the error message in both the build and test logs so we report the match twice. This is something we can prevent by not excluding test matches from the build report

@ulisesh
Copy link
Contributor

ulisesh commented Jan 30, 2023

@ulisesh
Copy link
Contributor

ulisesh commented Feb 10, 2023

Validated with dotnet/runtime#35066 it should only test known issues but the error message is in the build logs too

@ulisesh ulisesh closed this as completed Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants