Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Maestro GitHub PAT used in CI #4081

Closed
oleksandr-didyk opened this issue Oct 22, 2024 · 4 comments
Closed

Replace Maestro GitHub PAT used in CI #4081

oleksandr-didyk opened this issue Oct 22, 2024 · 4 comments
Assignees

Comments

@oleksandr-didyk
Copy link
Contributor

Our scenario tests are currently relying on a personal GitHub PAT token for GitHub operations, such as clean-up.

We should replace it with a bot PAT token that is managed by secret manager.

@oleksandr-didyk
Copy link
Contributor Author

Discusser over Teams and decided to add replace both GitHub PAT tokens used in the build pipeline:

  • the scenario test one in the original scope of the issue
  • the arcade-services read-write one used for creating releases

Additionally, decided to use the fine-grained token type to limit how much access each token gives

@oleksandr-didyk oleksandr-didyk changed the title Replace Maestro GitHub PAT used for scenario tests Replace Maestro GitHub PAT used in CI Oct 24, 2024
@oleksandr-didyk
Copy link
Contributor Author

oleksandr-didyk commented Oct 24, 2024

After the tokens are replaced, we need to clean-up:

  • obsolete secrets from secret manager manifests
  • obsolete secrets in Maestro and PCS Key Vaults
  • obsolete variable groups and service connections used for the variable groups

Additionally, if we need to add any new variable groups or service connections we should make sure they have adequate ownership setup for the team

@oleksandr-didyk
Copy link
Contributor Author

Removal of an obsolete reference to the previous Maestro scenario test token - https://dev.azure.com/dnceng/internal/_git/dotnet-release/pullrequest/44522

This was referenced Oct 30, 2024
@oleksandr-didyk
Copy link
Contributor Author

Removed obsolete variable groups from AzDO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants