Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor code issue #2133

Closed
andrew-kuzovov opened this issue Aug 22, 2023 · 2 comments · Fixed by #2136
Closed

Minor code issue #2133

andrew-kuzovov opened this issue Aug 22, 2023 · 2 comments · Fixed by #2136
Labels
🆕 Triage Needed For new issues, not triaged yet.

Comments

@andrew-kuzovov
Copy link

SqlClient/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs

Line 2429 in 3185ce2

};

@JRahnama JRahnama added the 🆕 Triage Needed For new issues, not triaged yet. label Aug 22, 2023
@JRahnama JRahnama mentioned this issue Aug 22, 2023
Merged
@JRahnama
Copy link
Contributor

Empty statements are valid in C# and have some use-cases. This, however seemed oversighted, but had no effect on perf or caused any issue at compile time. For code-cleanup purposes I have addressed it in PR #2136 .

@JRahnama
Copy link
Contributor

Closing the issue as PR #2136 is made to address the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🆕 Triage Needed For new issues, not triaged yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove empty statement JRahnama/SqlClient
2 participants
@andrew-kuzovov @JRahnama