Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Remove unused PictureCommand enum #454

Closed
wants to merge 1 commit into from
Closed

Remove unused PictureCommand enum #454

wants to merge 1 commit into from

Conversation

jsuarezruiz
Copy link
Contributor

It is a public enum that is not used and can cause confusion. @jonlipsky What do you think here?, what was the purpose of the enum?

Fixes #129

@jsuarezruiz jsuarezruiz added the bug Something isn't working label Jun 21, 2022
@jonlipsky
Copy link
Contributor

@jsuarezruiz It's not currently in use, but it will be in use soon.

I wanted the API to stabilize before I brought over the code that will use it. Its intended use is to provide something similar to SkPicture within Skia: a way to serialize and replay a set of drawing commands.

It will be key to addressing these issues:
#244
#245

Additionally, there is one other use that you may find interesting that I use in all of my personal apps. Instead of bundling images in a vector format such as SVG or PDF (on iOS), I bundle my images in my apps using this binary "picture" representation, which is faster to load/parse and is faster to render.

@jsuarezruiz
Copy link
Contributor Author

Got it. Feel free to close the PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PictureCommand unused
2 participants