Fixed latent bug in MqttApplicationMessageBuilder.WithPayload stream overload #1322
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. Good work 👍 |
|
wouldn't it be better to only start a loop when the first read returns less bytes? |
|
@jogibear9988 that's basically done with the It reads, and when read less than expected, so loop. |
|
I only thought it would maybe more effective. But I've not analyzed the IL... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stream.Readcan read less than requested bytes, so we need read in a loop until either the requested byte-count is read or 0 is returned.It's hard to construct a proper test for this, but that behavior is documented.