Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTTnet source and nuget package no longer appear to support .Net Framework #80

Closed
cshepley opened this issue Oct 25, 2017 · 7 comments
Closed

Comments

@cshepley
Copy link

cshepley commented Oct 25, 2017

While .Net Standard, UWP and .Net Core seem to work just fine, there is currently no assembly in the nuget package supporting the .Net Framework, and building from source causes output to contain numerous indirect references, making it unusable without many modifications to referencing projects.

@chkr1011
Copy link
Collaborator

@JanEggers Can you have a look here? You introduced the new project which supports both frameworks in one file. I have no idea what's wrong with that project.

@JanEggers
Copy link
Contributor

JanEggers commented Oct 25, 2017

im currently using version 2.4 with net461 the changes i did to the project structure are just in develop branch so i think there should not be a package. @cshepley what is the version of the package u use without netfx support? i just verified latest package is 2.4 and it contains a net45 folder. also what are the issues when building the source? a little more details pls.

@chkr1011
Copy link
Collaborator

@JanEggers Yes you are right. I am focused on next version 😄

@chkr1011
Copy link
Collaborator

@cshepley Does this problem still exist? If yes can you provide some error messages etc. so we can check? If I don't get a reply I assume it is fixed and thus I will close this ticket. If this is wrong please reopen it if required.

@schtibb
Copy link

schtibb commented Nov 3, 2017

Greetings,

I just tried installing MQTTnet.2.4.0 on my .net framework 4.6.1 project and it require me to also install NetStandardLibrary.1.6.1, Microsoft.NETCore.Platforms.1.1.0 and a bunch of other packages as dependencies. Is it supposed to require all that?

image

@schtibb
Copy link

schtibb commented Nov 3, 2017

When I changed my project to .net framework 4.5 (from 4.6.1) it seems to not require all the packages listed in the previous posts.

image

@JanEggers
Copy link
Contributor

that is because Visual Studio chooses netstandard dll as net461 is closer to standard1.6 then to net45.

but the many packages are the way netstandard works, in dotnet core 2.0 ms introduced some "tree shaking" to remove unneeded packages / packages that are already on the machine when installing .net core runtime.

but until we upgrade to netstandard 2.0 that is the way its supposed to be i guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants