Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document breaking changes in the update pipeline #3769

Closed
3 of 4 tasks
roji opened this issue Mar 16, 2022 · 6 comments
Closed
3 of 4 tasks

Document breaking changes in the update pipeline #3769

roji opened this issue Mar 16, 2022 · 6 comments
Assignees

Comments

@roji
Copy link
Member

roji commented Mar 16, 2022

@ajcvickers
Copy link
Contributor

@roji I didn't work on this when doing the 7.0 breaking changes because I'm not sure what needs doing where.

@roji
Copy link
Member Author

roji commented Sep 21, 2022

Yeah, to be honest, I'm not sure what user-facing breaking changes we have here (apart from the trigger trouble which is already documented). The fact we no longer wrap single statements in a transaction may theoretically cause a behavior change in some scenarios, but I'd have to think hard to find such a scenario (we should maybe wait until a user hits one?).

(There are certainly many provider-facing breaking changes here, but I'm not a fan of doing a breaking change note for those)

@ajcvickers
Copy link
Contributor

Agreed.

@ErikEJ
Copy link
Contributor

ErikEJ commented Sep 21, 2022

Maybe that EF Core runs too fast now? 🤣

@roji
Copy link
Member Author

roji commented Sep 21, 2022

@ErikEJ something like this...

@ErikEJ
Copy link
Contributor

ErikEJ commented Sep 21, 2022

Exactly. Luckily you have a "go slow" switch.

@ajcvickers ajcvickers removed this from the 7.0.0 milestone Sep 21, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants