Added comment to not call GC.Collect.

dotnet · May 26, 2024 · 9e042a3 · 9e042a3
1 parent 48c5591
commit 9e042a3
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/BenchmarkDotNet/Engines/GcStats.cs b/src/BenchmarkDotNet/Engines/GcStats.cs
@@ -145,6 +145,8 @@ public static GcStats FromForced(int forcedFullGarbageCollections)
             if (RuntimeInformation.IsWasm)
                 return null;
 
+            // Do NOT call GC.Collect() here, as it causes finalizers to run and possibly allocate. https://github.com/dotnet/runtime/issues/101536#issuecomment-2077533242
+            // Instead, we call it before we start the measurement in the Engine.
 #if NET6_0_OR_GREATER
             return GC.GetTotalAllocatedBytes(precise: true);
 #else