Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an ODATA security doc #12115

Closed
Rick-Anderson opened this issue Apr 23, 2019 · 11 comments · Fixed by MicrosoftDocs/OData-docs#74
Closed

Create an ODATA security doc #12115

Rick-Anderson opened this issue Apr 23, 2019 · 11 comments · Fixed by MicrosoftDocs/OData-docs#74
Assignees
Labels
Milestone

Comments

@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Apr 23, 2019

Create an ODATA security doc
Port over Security Guidance for ASP.NET Web API 2 OData

@Rick-Anderson Rick-Anderson self-assigned this Apr 23, 2019
@Rick-Anderson Rick-Anderson added this to the Backlog milestone Apr 23, 2019
@Rick-Anderson
Copy link
Contributor Author

@FIVIL is there anything like The [Queryable] attribute for ASP.NET COre?
See Query Validation

@Rick-Anderson
Copy link
Contributor Author

@FIVIL [EnableQuery(PageSize =10)] works

@Rick-Anderson
Copy link
Contributor Author

@FIVIL See Query Validation

Can you create a sample using MyQueryableAttribute for ASP.NET Core?

@FIVIL
Copy link
Contributor

FIVIL commented Apr 23, 2019

@Rick-Anderson
[EnableQuery] seems to be Successor of [Queryable] in OData v4. so I think generally speaking [Queryable] is not a case with asp.net core and works for MVC and legacy versions.
but overriding EnableQueryAttribute and query validations is possible with ASP.net core.

@FIVIL
Copy link
Contributor

FIVIL commented Apr 23, 2019

@Rick-Anderson
sure. I will add an example of Query Validation
just to be sure should i add new examples to existing tutorials, or should i create a new MD file. like the documentation of ASP.NET MVC

@Rick-Anderson
Copy link
Contributor Author

@FIVIL just create the sample for now. Create a PR with the sample in AspNetCore.Docs\aspnetcore\web-api\advanced\odata-security\samples

@FIVIL
Copy link
Contributor

FIVIL commented Apr 23, 2019

@Rick-Anderson
Sure, I'll try to submit the pull request ASAP (within a day)

@FIVIL
Copy link
Contributor

FIVIL commented Apr 24, 2019

@Rick-Anderson
under which branch should i search for AspNetCore.Docs\aspnetcore\web-api\advanced\odata-security\sample ?

@FIVIL
Copy link
Contributor

FIVIL commented Apr 24, 2019

@Rick-Anderson
well, I thought you already added a folder at that path. but now I realized that's not the case.
ill add it under my own branch (OData)

@Rick-Anderson
Copy link
Contributor Author

@FIVIL sorry, yes.. Just create it in your PR.

@FIVIL FIVIL mentioned this issue Apr 24, 2019
@FIVIL
Copy link
Contributor

FIVIL commented Apr 24, 2019

@Rick-Anderson
i couldn't add new commits to my other PR. so i created a new PR #12137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants