Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More detailed error messages in C++ nodes #448

Closed
phil-opp opened this issue Apr 2, 2024 · 0 comments · Fixed by #450
Closed

More detailed error messages in C++ nodes #448

phil-opp opened this issue Apr 2, 2024 · 0 comments · Fixed by #450
Assignees
Labels
bug Something isn't working c++

Comments

@phil-opp
Copy link
Collaborator

phil-opp commented Apr 2, 2024

The cxx crate that we use to bridge between Rust and C++ uses the Display implementation of errors. For eyre::Report errors, this means that only the outer context is printed, e.g. "failed to receive response". For debugging, it would be useful to use the Debug output instead, which prints the underlying causes as well.

To implement this, we could do a map_err(|e| eyre::eyre!("{e:?}")) call before returning to C++.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c++
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant