Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle network error #186

Merged
merged 2 commits into from
Jun 9, 2018
Merged

Handle network error #186

merged 2 commits into from
Jun 9, 2018

Conversation

wasedaigo
Copy link
Contributor

When I tested with Airplane mode, getProduct never resolved/rejected the promise. Fix this by handling the delegate properly.

@hyochan
Copy link
Owner

hyochan commented Jun 9, 2018

Thank you for the PR. Have you tested this? If so will publish to new npm version.

@hyochan hyochan merged commit 999a1df into hyochan:master Jun 9, 2018
@wasedaigo
Copy link
Contributor Author

tested and released in production :)

@hyochan hyochan added the 🛠 bugfix All kinds of bug fixes label Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🛠 bugfix All kinds of bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wasedaigo @hyochan