Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Refactoring - Separate and Test Weekdays row #77

Merged
merged 11 commits into from
Mar 1, 2019
Merged

[WIP] Refactoring - Separate and Test Weekdays row #77

merged 11 commits into from
Mar 1, 2019

Conversation

edTheGuy00
Copy link
Collaborator

@edTheGuy00 edTheGuy00 commented Feb 27, 2019 •
edited
Loading

As discussed in #67

@hyochan I'm not sure about your comment When FIRSTDAYOFWEEK is 0 in dart-intl, it represents Monday. but I found that when using weekdays from dateSymbols Sunday is the first day, you can check it out here

So I went ahead and omitted using firstDayOfWeek like you were previously doing.

@edTheGuy00 edTheGuy00 mentioned this pull request Feb 27, 2019
Closed
@edTheGuy00 edTheGuy00 requested a review from hyochan February 28, 2019 06:51
hyochan
hyochan approved these changes Mar 1, 2019
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve this PR 🎉

@hyochan hyochan merged commit e943b34 into hyochan:master Mar 1, 2019
@hyochan hyochan added the enhancement New feature or request label Mar 1, 2019
@edTheGuy00 edTheGuy00 mentioned this pull request Mar 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edTheGuy00 @hyochan @edgartrem