Ability to choose the weekday format on the constructor #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vinsalmont Thank you for the |
|
@hyochan Hello there! No problem, I'll provide the Readme. |
|
@vinsalmont Thanks. Also, It would be great if you post some screenshots and example code in here for me to test live. |
|
@hyochan I'm working on it and later I'll update the PR, thanks! |
hyochan
reviewed
Jan 9, 2019
hyochan
reviewed
Jan 9, 2019
| @@ -71,6 +71,7 @@ For help getting started with Flutter, view our online | |||
| | maxSelectedDate | `DateTime` | | | |||
| | inactiveDaysTextStyle | `TextStyle` | | | |||
| | inactiveWeekendTextStyle | `TextStyle` | | | |||
| | weekDayFormat | `WeekdayFormat` | `short` | | |||
There was a problem hiding this comment.
How about changing this into an enum type?
|
@vinsalmont Thank you for the update. I've add some comments on your |
|
@vinsalmont I'll just merge this since you seem quite busy. I'll try to update my review in a further update. Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.