-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedup causing animation errors #923
Comments
Hi @timothyallan, thanks for reporting the issue! I'm having trouble seeing a difference in the exported file - if that's obvious to you maybe we're getting different results somehow, could you share the resulting file? .ZIP files can be attached to github comments. Or if it's less obvious I may need a screenshot or screencapture to see the issue. |
Ohh that's interesting, I didn't think it might be a platform dependent issue. I've attached the post dedup model + an mp4 so you can see the issue. https://user-images.githubusercontent.com/1995135/234376589-3116cc47-df6c-4514-b2d1-1672acbd59d4.mp4 |
I've reduced the model to a simplified version containing just the two flags, and the issue appears pretty clearly here: Interestingly, I don't see the same problem when viewing the model in Babylon.js (https://sandbox.babylonjs.com/) so I think this may be an engine-related bug, occurring when a geometry is reused with different morph target animation. Will file a ticket on the three.js repository in a bit.
|
Fixed in three.js upstream, should be available in the viewer after the next release or two. Thanks for the report! |
Thanks Don, I appreciate all the work you do for the community! |
I've got an odd one where dedup causes an issue with one part of a model which is animated. Works great before dedup, afterwards, the animation is botched up.
Grab the .glb of this free model https://sketchfab.com/3d-models/medieval-fantasy-book-06d5a80a04fc4c5ab552759e9a97d91a , pop it into https://gltf.report/ , change the the default script to only include dedup and run it i.e.
export the processed model, import into https://gltf-viewer.donmccurdy.com/ to get the animations going and look at the second flag animating on the tower.
The text was updated successfully, but these errors were encountered: